[TYPO3-core] RFC #10565: Speedup / Cleanup t3lib_match_condition - make use of trimExplode
Steffen Kamper
info at sk-typo3.de
Sat Feb 28 13:00:33 CET 2009
Hi Benni,
Benjamin Mack schrieb:
> Hey Steffen,
>
> thanks for the review.
>
> First of all, the following code glues an existing array together! It
> does not split it! (which would be explode).
>
> $userTS = implode($TSdataArray, chr(10).'[GLOBAL]'.chr(10));
> $userTS = implode(chr(10) . '[GLOBAL]' . chr(10), $TSdataArray);
>
> ====
>
> And then: This is no functional change. Please read
> http://de.php.net/manual/en/function.implode.php
>
> "Note: implode() can, for historical reasons, accept its parameters in
> either order. For consistency with explode(), however, it may be less
> confusing to use the documented order of arguments."
>
> ====
>
> All the best,
> Benni.
ah i see, i misunderstood. And the parameter order was new to me, so no
concerns on that.
vg Steffen
More information about the TYPO3-team-core
mailing list