[TYPO3-core] RFC #10565: Speedup / Cleanup t3lib_match_condition - make use of trimExplode

[Steffen Kamper]

Hi Benni,

great, this makes code much better readable, and the right methods are used.

I have one concern with the very first chunk

$userTS = implode(chr(10) . '[GLOBAL]' . chr(10), $TSdataArray);

This won't work if userTS starts with "[GLOBAL]" - what is the reason 
here for your change? IIRC the statement GLOBAL is added in general.

The rest is fine by reading and i will test it in the afternoon to give 
the final +1

vg Steffen

Benjamin Mack schrieb:
> Hey all,
> 
> Patch type: cleanup
> 
> BT reference: http://bugs.typo3.org/view.php?id=10565
> 
> Branches: trunk only
> 
> Problem: Although we have a good API for trimming and exploding, we 
> don't make use of it in t3lib_match_condition.
> 
> This cleanup is a bigger result of splitting the "tsconfig condition" 
> patch into cleanup and functional changes. While extracting these 
> changes, I added some more cleanups.
> 
> 
> Solution: Change some checks, loops and functions to faster functions 
> and loops, add some whitespaces.
> 
> And thus: Request for comments!
> 
> Once this one is in the core, I will start working on the tsconfig 
> condition patch Olly and Bernhard prepared 1.5 years ago.
> 
> All the best,
> Benni.
>