[TYPO3-core] RFC: #10025: ImageMagick generates larger than necessary files

Ingo Renner ingo at typo3.org
Sun Feb 15 17:52:25 CET 2009


Helmut Hummel wrote:

Steffen,

>>>> $GLOBALS['TYPO3_CONF_VARS']['GFX']['no_strip'] = true;
>>>
>>> Didn't we agree to not use no double negation? ;)
>>
>> where is double negation?
> 
> no_strip = true
> 
> Why not use "strip=false" or even better, be a bit more descriptive like:
> 
> strip_exif_data or stripExifData, whatever is more apropriate here...

I strongly agree with helmut here, please use a name that describes the 
setting and is not negated. Those negated variables are highly 
confusing. I'd suggest using stripExifdataFromThumbnails.


all the best
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2


More information about the TYPO3-team-core mailing list