[TYPO3-core] RFC #12505: Bug: JSMENU's showActive is broken

Joerg Wagner [DigiLog] news.netfielders.de at digilog.de
Tue Dec 8 10:16:33 CET 2009


Great Benjamin,

these threads are are a bit frayed out now, so the best resource for the 
latest patch versions and directions on how to reproduce the problems is 
surely the bugtracker.

Cheers,
Jörg.


Benjamin Mack schrieb am 07.12.2009 07:59:
> hi jörg,
> 
> i will review this and your other patch this week, so it'll go into 
> 4.3.1, 4.2.11 (is it 11?) and trunk.
> 
> All the best,
> Benni.
> 
> On 03.12.09 13:32, Joerg Wagner [DigiLog] wrote:
>> Anybody willing to commit this?
>> Just a kind reminder!
>> JSMENU is _very_ broken right now.
>>
>> Cheers, Jörg.
>>
>>
>> Joerg Wagner [DigiLog] schrieb am 08.11.2009 19:11:
>>> This is an SVN patch request.
>>>
>>> Type: Bugfix
>>>
>>> Bugtracker references:
>>> http://bugs.typo3.org/view.php?id=12505
>>>
>>> Branches:
>>> TYPO3_4-2 & trunk
>>> TYPO3_4-3 & trunk
>>>
>>> Problem:
>>> The implementation of the JSMENUITEM property "showActive" is (very)
>>> flawed. It only works for a small subset of all possible HMENU
>>> configurations.
>>>
>>> Solution:
>>> The problem is simple to solve. The JSMENU code to determine if a page
>>> is active is very simplistic and will not work in a large number of
>>> more complex cases. Funny thing is that there is a dedicated method in
>>> the same PHP file that does the job and does it right. JSMENU just
>>> does not use it. The patches contain a one-line fix that is thoroughly
>>> tested in many HMENU constellations.
>>>
>>> Cheers, Jörg.
>>>
> 


More information about the TYPO3-team-core mailing list