[TYPO3-core] RFC: #10853: [Feature] New Multimedia CE

Oliver Hader oliver at typo3.org
Mon Aug 31 11:30:58 CEST 2009


Hi Steffen,

Steffen Kamper schrieb:
> Hi,
> 
> FYI: committed to trunk, rev 5851
> 
> vg Steffen

Some remarks to the last patch:

* in ext_tables.php the media types hook are always included - it's not
required to do that for every request to TYPO3
-> add the class name to the core_autoload, remove the include_once()
and everything should work right it does now

* class tx_cms_mediaItems should be a singleton since the class has no
state at all

* in tslib_cObj there's the following
  * @file_exists(PATH_site . $url) ? 'file' : 'url'
    -> please avoid the "@" here
    -> however checking for an URL should be different (e.g. typolink)
  * the mode is set from 'url' to 'file' when forcePlayer is set, why?
  * the encapsulasion is missing, please define methods as public or
prodected concerning on their disposal


Besides that the documentation should state the difference between the
old MUTLIMEDIA and new MEDIA object or give a suggestion on how to use it.

Thanks in advance for taking care of the changes!

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3


More information about the TYPO3-team-core mailing list