[TYPO3-core] RFC #11764: speed up list module by improving internal handling of localisations

Rupert Germann rupi at gmx.li
Mon Aug 24 11:17:41 CEST 2009


hi Masi,

Martin Kutschker schrieb:
> Please be consistent with the spacing (I prefer space after comma, no
> spaces around =, but check CGL). The doc comment for the new argument is
> missing!

right. I'll change this during commit.
$this->translations is missing an initialization, too.

> $this->translations = FALSE;
> 
> IIRC CGL require booleans in lower case.

IIRC it's uppercase ;-)

searched the CGL for "boolean", "bool", "true"
-> no result
searched for "false"
-> one result in a code example in lowercase

seems that this needs some clarification.

greets
rupert


More information about the TYPO3-team-core mailing list