[TYPO3-core] RFC: #10040: define Default GET-vars

Michael Stucki michael at typo3.org
Mon Aug 17 12:46:43 CEST 2009


Hi Steffen,

>> 1. There was a feedback from Benni about the naming of this key. Why did
>>    you ignore it? I agree with him that "defaultGetVars" may fit better.
>>
> 
> i used Benni's latest suggestion:
> 
> config._DEFAULT_GET_VARS {
>   data.fe_users.1.username = defaultfeusername
> }
> I would be also fine with defaultGetVars, but _DEFAULT_GET_VARS would be
> same like _DEFAULT_PI_VARS, so your decision ;)

What is the relation between the two? => There is none.

>> 2. He also mentions an eventual security problem. Therefore, please send
>>    this change to the security team before you commit it no matter of
>>    the feedbacks on this list.
> 
> i will do, but  _DEFAULT_PI_VARS also writes to GET.

Thanks. Better safe than sorry.

>> 3. Notice that this is the first ever option for "config." that has more
>>    than one property level (= it is multi-dimensional). Please check if
>>    this will also work if specified in "page.config...." etc.
> 
> core internally merge config and page.config, so it appears in
> $this->config['config']. I checked.

I just wanted to mention that we'll use this for the first time. If you
are sure that this has no side-effects, go ahead.

- michael

-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/


More information about the TYPO3-team-core mailing list