[TYPO3-core] RFC: #11731: [Bugfix] ENABLE_INSTALL_TOOL file check in yellow box doesn't check the file age

[Michael Stucki]

Hi Francois & Moreno Party-Man ;-)

>> No, you didn't get anything wrong. The problem is it could confuse
>> people because the file will only be removed after the install tool
>> was accessed. If you see the warning in the yellow box and you want to
>> check whether the install tool is accessible it could be that your
>> install tool deletes the file.
>>
>> The bug is more about "confusing people" than a technical change.

I agree. Actually the real problem is that the file is already
"scheduled" for removing but it will not be done before you access the
Install Tool. So maybe the file removal should be integrated in
typo3/init.php instead?

> I understand better what you mean now. However, I'm still unfavorable to
> the change you suggest: the fact is that the ENABLE_INSTALL_TOOL file
> exists at that point and something should be done about deleting it. I
> agree that it may cause some confusion, but the proposed is fixed is not
> a good solution IMO.
> 
> Moreover your patch is wrong, because it doesn't take into account the
> "KEEP_FILE" feature.

True. Now by copying the removal code from typo3/install/index.php to
typo3/init.php this would be considerated, so nothing would need to be
changed in class.t3lib_befunc.php.

What do you think?

- michael

-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/