[TYPO3-core] RFC #11431: Hook request for manipulating the pageID in getPage

[Oliver Hader]

Hi Christian,

Christian Kuhn schrieb:
> Hey,
> 
> Steffen Kamper wrote:
>> +1 on reading. I applied and saw no error, but i didn't wrote a testhook 
>> for this. As the hook is defined like the other ones a expect the hook 
>> working.
> 
> Thanks! Yep, hooks are usually hard to test in a useful matter. In this
> case I would like to bend the rules a tiny bit and commit this one in 72
> hours if nobody objects meanwhile, even without the missing +1 on
> testing. Please stand up now.
> 
> This hook is working and used in a production environment for quite some
> time, but it would take me at least two hours to set up a really useful
> test extension and environment.
> 
> I'll also forward this message explicitly to Oliver, so the RM has a
> chance to veto my egoistic decision.

Thanks for your reminder. I see that it is a problem that RFCs are not
tested enough and thus are blocked from being integrated into the Core.
This problem could be solved by using unit tests as much as possible. In
this case it would be possible to use a mock and check whether the hook
method gets called with the expected values.

I'm going to have a look later this day and could possibly also create
that test case...

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3