[TYPO3-core] RFC: #10550: Listview: default limits are hardcoded

[Steffen Kamper]

Hi Christian,

Christian Kuhn schrieb:
> Hi,
> 
> Steffen Kamper wrote:
>> The limits of records in list view depend on TCA setting of the tables.
>>
>> $TCA[$tableName]['interface']['maxSingleDBListItems']
>> $TCA[$tableName]['interface']['maxDBListItems']
>>
>> If these values are not set, default values are hardcoded:
>> var $itemsLimitPerTable = 20;
>> var $itemsLimitSingleTable = 100;
>>
>> the following patch allows to override default settings with pageTS or
>> userTS:
>>
>> mod.web_list.itemsLimitSingleTable = 50
>> mod.web_list.itemsLimitPerTable = 10
> 
> Nice patch. I had something similar in mind.
> 
> Remarks:
> - doc_core_tsconfig documentation missing.
>
will do when commit.


> - I would prefer itemsLimitMultiTable instead of ..PerTable (personal
> taste).
>

i would like to use same naming in config and php for better 
understanding. Both names are not selfexplaining, that's what the 
documentation is for.

> - This is the now the order of which setting takes precedence:
> 1. If GET showLimit if set in single table mode, use this. (This can be
> set with the input box at the very bottom of the page, called "Show
> records").
> 2. If TCA maxSingleDBListItems / maxDBListItems is set for a table, use
> this.
> 3. If mod.web_list.itemsLimitSingleTable /
> mod.web_list.itemsLimitPerTable is set, use this.
> 4. Last fallback is hardcoded value.
> 
> I personally would like to see 2. and 3. switched, so that your new
> pageTSconfig takes precedence of TCA, but I don't insist on this.
> (Pages table has this setting in TCA with maxDBListItems=30 and
> maxSingleDBListItems=50.)
> 

the initializtion is right at the beginning, so the setting only 
substitute the hardcoded ones. Overriding with GET should be in the 
later code and is untouched, so here is no change of behaviour.

> 
> Anyway, +1 on reading and testing, also if my remarks are not taken into
> account.
> 

I wait for your comment ;-)

vg Steffen