[TYPO3-core] RFC #9400: Integrate jb_status_code in the TYPO3 core

Steffen Kamper info at sk-typo3.de
Tue Sep 23 10:10:46 CEST 2008


Hi Masi,

Martin Kutschker schrieb:
>> $domain = explode(':', $domain);
>> should be t3lib_div::trimExplode
> 
> Why do we need to remove whitespace?
>

the reason for me mostly usage of trimExplode is not only trim but also 
filter out empty. The question is if we can rely on this string.

>> 2)
>> $domain = strtolower(ereg_replace('\.$', '', $domain[0]));
>> using trimExplode makes this ereg_replace useless
> 
> How? The regexp removes a final dot.
> 
yes, corrected that in a skype conversation.

>> strtolower also my dangerous with umlaut-domains
> 
> Won't they be in their enocoded Puny code form at this point? Just
> because you see an umlaut that doesn't mean it goes over the wire in
> that form.
>

same as above, there is no need for strtolower. See the last patch where 
these things are corrected ;-)

vg Steffen


More information about the TYPO3-team-core mailing list