[TYPO3-core] RFC #9400: Integrate jb_status_code in the TYPO3 core

[Martin Kutschker]

Steffen Kamper schrieb:
> Hi,
> 
> Susanne Moog schrieb:
>> Steffen Kamper schrieb:
>>> Hi,
>>>
>>> this patch doesn't apply for me
>>> "The chunk size did not match the number of added/removed lines"
>>>
>>> Beside that, why not using a select? It's easy with usage of the
>>> constants and should only contain the 3xx header
>>
>> Hi Steffen,
>>
>> please try again with attached patch. It should apply correct now.
>>
>> I also added a select box with Status 301,302,303 and 307.
>>
>> Regards,
>>
>> Susanne
>>
>>
> 
> ok, now patch applies.
> 
> +1 for general, now it makes sense with the select box!
> 
> Some remarks that should be modified:
> 1)
> $domain = explode(':', $domain);
> should be t3lib_div::trimExplode

Why do we need to remove whitespace?

> 2)
> $domain = strtolower(ereg_replace('\.$', '', $domain[0]));
> using trimExplode makes this ereg_replace useless

How? The regexp removes a final dot.

> strtolower also my dangerous with umlaut-domains

Won't they be in their enocoded Puny code form at this point? Just
because you see an umlaut that doesn't mean it goes over the wire in
that form.

Masi