[TYPO3-core] RFC: #9372: Code in class.tx_tstemplateanalyzer.php don't match with the new CGL

Steffen Kamper info at sk-typo3.de
Thu Sep 18 12:29:00 CEST 2008


Stefano Kowalke schrieb:
> Hey,
> 
>>> sry for the late - i don't like $GLOBALS['tmpl'], which is a approach we
>>> don't use anywhere for this purpose.
>>> You can change that to a class var, so $this->tmpl is available in any
>>> function then.
>> Did you analyse the code? There must be a reason this variables are
>> defined as globals.
> 
> Some variables which defined as global was not used:
> * $theConstants defined in initialize_editor() and main() as global but not
> using
> * $rootLine defined in main() as global but not using
> 
> * $tmpl and $tplRow was initiated by initialize_editor() and was using in
> initialize_editor() and main() so this is IMHO the reason for defining as
> globals
> 
> Stefano 

tmpl is initialized in this class, so it's not needed to fiddle with 
global object, test my modified patch.

tmplRow comes from parent class.

vg Steffen


More information about the TYPO3-team-core mailing list