[TYPO3-core] RFC: #9372: Code in class.tx_tstemplateanalyzer.php don't match with the new CGL

Stefano Kowalke blueduck at gmx.net
Thu Sep 18 12:23:22 CEST 2008


Hey,

>> sry for the late - i don't like $GLOBALS['tmpl'], which is a approach we
>> don't use anywhere for this purpose.
>> You can change that to a class var, so $this->tmpl is available in any
>> function then.
> 
> Did you analyse the code? There must be a reason this variables are
> defined as globals.

Some variables which defined as global was not used:
* $theConstants defined in initialize_editor() and main() as global but not
using
* $rootLine defined in main() as global but not using

* $tmpl and $tplRow was initiated by initialize_editor() and was using in
initialize_editor() and main() so this is IMHO the reason for defining as
globals

Stefano 
-- 
Seit dem 1.1.2008 werden Daten zu jeder E-Mail verdachtsunabhängig gespeichert! 
Weitere Informationen: www.vorratsdatenspeicherung.de
GPG-ID: 0x2B08936D
Key-Fingerprint: 7F31 BCF0 70C0 B3B1 1235 07E9 1777 D7A0 2B08 936D


More information about the TYPO3-team-core mailing list