[TYPO3-core] RFC #8621: Whitespace and CGL cleanup for class.tx_opendocs.php

Benjamin Mack benni at typo3.org
Mon Sep 15 06:04:44 CEST 2008


Thanks, couch neighbour :)

commited to trunk only (I don't see a need to commit only a CGL cleanup 
to any other branch).

Jeff Segars wrote:
> +1 after reading.  Looks good to me :)
> 
> Thanks,
> Jeff
> 
> Benjamin Mack wrote:
>> Hey Stefano,
>>
>> looks good now.
>>
>> +1 after reading. However, there is more testing needed :)
>>
>>
>>
>> Stefano Kowalke wrote:
>>> Benjamin Mack wrote:
>>>
>>>> Hey Stefano,
>>>>
>>>> nice work. Will only go in "trunk" though (don't seem to be urgent 
>>>> so we
>>>> need this in a stable version).
>>>>
>>>> While reading I also noticed this:
>>>>
>>>> if(count($entries)) {
>>>>
>>>> Should be
>>>>
>>>> if (count($entries)) {
>>>>
>>>> right?
>>>
>>> Right.
>>>
>>> Look at the patch which i attached.
>>>
>>> Stefano 
>>>
>>>
>>>
>>

-- 
All the best,
benni.
-SDG-


More information about the TYPO3-team-core mailing list