[TYPO3-core] RFC #8621: Whitespace and CGL cleanup for class.tx_opendocs.php

Jeff Segars jsegars at alumni.rice.edu
Mon Sep 15 06:01:31 CEST 2008


+1 after reading.  Looks good to me :)

Thanks,
Jeff

Benjamin Mack wrote:
> Hey Stefano,
> 
> looks good now.
> 
> +1 after reading. However, there is more testing needed :)
> 
> 
> 
> Stefano Kowalke wrote:
>> Benjamin Mack wrote:
>>
>>> Hey Stefano,
>>>
>>> nice work. Will only go in "trunk" though (don't seem to be urgent so we
>>> need this in a stable version).
>>>
>>> While reading I also noticed this:
>>>
>>> if(count($entries)) {
>>>
>>> Should be
>>>
>>> if (count($entries)) {
>>>
>>> right?
>>
>> Right.
>>
>> Look at the patch which i attached.
>>
>> Stefano  
>>
>>
>>
>>
> 


More information about the TYPO3-team-core mailing list