[TYPO3-core] RFC: #9312: felogin: uninitialized vars

Benjamin Mack benni at typo3.org
Mon Sep 8 21:07:02 CEST 2008


Hey Steffen,

I reworked the patch, there was a small problem with the empty lines. I 
commited the attached patch to 4.2 and trunk. It really /is/ a nobrainer.

However, although your code is now cleaner, we should have a proper 
handling within substitueMarkerArrayCached to throw an exception when 
the Array does not exist or we do type hinting or we just say
if (!is_array($markers) {
	$markers = array();
}
dunno.

Thanks for fixing the issue.

-- 
All the best,
benni.
-SDG-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: felogin_initVars.diff
Type: application/octet-stream
Size: 1458 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080908/8ca9c1f5/attachment.obj 


More information about the TYPO3-team-core mailing list