[TYPO3-core] RFC #9284: Feature: tt_content.starttime/endtime have now effect on caching (with patchfile now, sry)

[Ingo Renner]

Hi Martin,

here's a review on the code:

* the diff is not against the root of TYPO3 (not a big problem though, 
just keep that in mind)
* line 10: until there's a final decision about the indentation of 
inline comments and until this decision is released, inline comments are 
indented with one tab (also applies to all other inlne comments in your 
patch)
* line 12: $_classRef -> $classReference
* line 13: no need for the ampersand, PHP4 times are over
* line 14: you either check whether this method exists or go with (the 
better way of) requiring the object to implement an interface (check 
t3lib/interfaces/ f.e.)
* line 18: $sys_page -> $pageSelect / $pageSelection / $pageSelector
* line 23: split the parameter of exec_SELECTquery onto one line each
* lines 46, 50: no need for a log here (IMO)

In general you can't use the default cache period for calculations, 
there's a separate field for the cache period in table pages, use this 
field's value.


best
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2