[TYPO3-core] RFC: Feature #7572: Extend $TSFE for FeUsers in table sys_lockedrecords

Stefan Geith typo3dev2008.nospam1 at geithware.de
Wed Oct 29 11:36:17 CET 2008


Hi Oliver,

Oliver Hader schrieb:
> ...
> Some annotations to your patch:
> * please define the function access "public function ..."
> * call "lockRecords" further "setRecordEditLock"
> * call "unlockRecords" further "removeRecordEditLocks"
> * integrate boolean return values for the set/remove methods that state
> whether the actions was successful
> * please use TYPO3_DB->fullQuoteStr() to escape strings for database
> disposal
> * instead of checking an FE-user array that might not exist, you can
> pre-check this by using $TSFE->loginUser
> * a method name beginning with "is" should return a boolean value in
> general - if information should be returned this can be done by calling
> a method with an array as reference that will be filled if available,
> e.g methodName($table, $uid, &$information = NULL)
> * inside isRecordLocked() you select all items of sys_lockedrecords and
> recude it later to the requested table name and its uid - this can be
> improved - I know that it's the same in t3lib_BEfunc, but that's no
> reason for copy&paste
> 
> I hope that you're still motivated to enhance your patch after my
> pedantic review. Thanks so far for the almost finished new feature!

Sure - I'll finish this in the beginning of next week - OK ?
> 
> One last thing: Please rock on! ;)

OK! ;)

-
Stefan


More information about the TYPO3-team-core mailing list