[TYPO3-core] RFC #9615: Move frontend editing to a system extension

[Steffen Kamper]

Hi Jeff,

thx for splitting, it's more easy to review. here it comes:

tslib.diff
===========
all is fine, it'S only the extraction of code replaced by wrappers

class.t3lib_frontendedit.diff
=============================


+			if(is_callable(array($this, $cmd))) {
+				$this->$cmd($table, $uid);
+			}
would be helpful to call an exception if action isn't available

$hideField = $GLOBALS['TCA'][$table]['ctrl']['enablecolumns']['disabled'];

before there was a check on $hideField, now there is no check. This 
cause a problem with
$recData[$table][$uid][$hideField] = 1;
when $GLOBALS['TCA'][$table]['ctrl']['enablecolumns']['disabled'] is 
NULL, is this filled all the time?

same in function unhide()


strtolower($conf['allow']

should be t3lib_div::strtolower($conf['allow'] for turkish reasons


There are some CGL-issues, the tabbed comments and some spaces missing 
after comma.


class.t3lib_tsfebeuserauth.diff
================================

Here is only cleanup and some little goodies like htmlspecialchars :-)

class.tx_feedit_adminpanel.diff
================================

$row .= '<img src="' . TYPO3_mainDir . 'gfx/ol/' . ...

please use scinning interface (and CGL)

  . chr(10)
just annotation - would be better to have global constant LINE_BREAK

function getHiddenFields, foreach($val as $k => $v)	{

please change to foreach($val as $valKey => $value)	{


.. some CGL like $out.=


+			while(list(,$row)=each($GLOBALS['BE_USER']->extPageInTreeInfo)) {

please use foreach

+			reset($GLOBALS['BE_USER']->extPageInTreeInfo);
+			while(list(,$row) = each($GLOBALS['BE_USER']->extPageInTreeInfo)) {

the same

function extGetHead: the scinning again.

function extItemLink: CGL

also the tabbed comments


class.tx_feedit_editpanel.diff
===============================

+			$content = (strlen($cBuf) && $securCount) ? substr($content, 0, 
strlen($cBuf)) . $icon . substr($content, strlen($cBuf)) : $content = 
$icon . $content;

this looks like a problem in utf8-mode with the native strlen, substr etc.

$cf1 = "if (confirm(" . t3lib_div::quoteJSvalue($confirm, true) . ")){";

should be single quotes


just a joke in between:
$tceforms->setFancyDesign() sounds like an easteregg :D


config_default.diff
====================
necessary addition.

So from code review i must say, good work! You did some very nice 
factoring like bundle code in an extension, use better variable names 
a.s.o. This is a huge patch and a lot of work in it, i'm sry for the CGL 
nitpicking.
A functional review will follow asap with my final voting :-)

vg Steffen