[TYPO3-core] RFC #9474: Integrate OpenID authentication support to TYPO3

[Ingo Renner]

Dmitry Dulepov wrote:

Dmitry,

> There's something wrong. I assume you refer to the main part of this 
> extension: sv1 service. Line 34 there is:

I'm always reffering to the line of the patch :)

> On many issues about variable names I think they are already good and 
> descriptive enough. I do not plan to change them. You can make a patch 
> to perfect variables, why not? This is personal taste, everyone has its 
> own and it is not bad :) We all can start renaming variables of others 
> (I already spotted some of yours that I'd like to rename) ;) But I doubt 
> it adds much value and makes our work effective, so I will not do it.

well, what's the sense of the review process then? Why not commit 
directly then?

> The time spent on this feature was large and I do not plan to invest any 
> more, unless I need to fix obvious bugs there. I am really sorry but I 
> truly do not have time for changing variable names. Other work is 
> planned and I must do that now.

Same here, what's the sense of a review then?



best
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2