[TYPO3-core] RFC #9400: Integrate jb_status_code in the TYPO3 core

[Dmitry Dulepov]

Hi!

Ernesto Baschny [cron IT] wrote:
> Ok, although I find it ugly. This distracts when reading a Changeset and
> trying to follow the *real* changes. :( Can you please point to the
> place where we agreed to work like that?

I can't. I do not want to spend time searching for it :( But we talked about serveral time recently: every patch must follow CGL now.

> Maybe we agreed to split up "cleanup" from "functional" changes in two
> different Changesets?

I think it is a good idea.

>> We use TYPO3 functions when possible. trimExplode is necessary here
>> because no one guaranties  that there will be no space.
> 
> There can be no space, because it is hostname:port that we are
> splitting. The protocol doesn't allow any "spaces". It there is a space,
> it is a bug in Apache or the Webserver who passed it wrongly to PHP.

Or in the calling function, who made the string like "host : 80". But it is a problem of the caller, he should pass it correctly, right? ;)

Speaking seriously, you are right. explode() is better in this case.

> I don't think so. It works great for me, thus my +1 (even tested).
> 
> And combined with your proposal from 27.9. "I may find time next week to
> test&commit it after doing small formatting changes."
> 
> I assume that is also a +1 on your side. So what do you think is missing?

It probably was CGL–related. But I do not have time for it now :(

-- 
Dmitry Dulepov
TYPO3 Core team
My TYPO3 book: http://www.packtpub.com/typo3-extension-development/book
In the blog: http://typo3bloke.net/post-details/iphone_as_productivity_tool/