[TYPO3-core] RFC #9474: Integrate OpenID authentication support to TYPO3

[Dmitry Dulepov]

Hi!

Ingo Renner wrote:
> Dmitry Dulepov wrote:
> 
>> if (TYPO3_OS == 'WIN') {
>>     // No random generator on Windows!
>>     define('Auth_OpenID_RAND_SOURCE', null);
>> } elseif (!is_readable('/dev/urandom')) {
>>     if (is_readable('/dev/random')) {
>>         define('Auth_OpenID_RAND_SOURCE', '/dev/random');
>>     } else {
>>         define('Auth_OpenID_RAND_SOURCE', null);
>>     }
>> }
> 
> No need for that IMO, if the device is not available (as it is the case 
> with WIN) it'll jump into the else branch anyways...
> The above code kinda duplicates code/functionality and also introduces 
> an unnecesarry check that slows down the stuff (although probably not much)

What if someone creates c:\dev\urandom with a predefined set of characters?

-- 
Dmitry Dulepov
TYPO3 Core team
My TYPO3 book: http://www.packtpub.com/typo3-extension-development/book
In the blog: http://typo3bloke.net/post-details/duplicate_content_with_realurl/