[TYPO3-core] RFC #9474: Integrate OpenID authentication support to TYPO3
Ingo Renner
ingo at typo3.org
Sat Oct 4 17:30:34 CEST 2008
Dmitry Dulepov wrote:
> if (TYPO3_OS == 'WIN') {
> // No random generator on Windows!
> define('Auth_OpenID_RAND_SOURCE', null);
> } elseif (!is_readable('/dev/urandom')) {
> if (is_readable('/dev/random')) {
> define('Auth_OpenID_RAND_SOURCE', '/dev/random');
> } else {
> define('Auth_OpenID_RAND_SOURCE', null);
> }
> }
No need for that IMO, if the device is not available (as it is the case
with WIN) it'll jump into the else branch anyways...
The above code kinda duplicates code/functionality and also introduces
an unnecesarry check that slows down the stuff (although probably not much)
Ingo
--
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2
More information about the TYPO3-team-core
mailing list