[TYPO3-core] RFC Bug #5611 Frontend preview and simulate time is buggy

[Ralf Hettinger]

Thank you for fixing this -considering the majority of use cases- and of
course for the nightshift ;)

Ralf

Am 11.11.2008 03:50 schrieb Michael Stucki:
> OK, I received Kaspers answer, but unfortunately he was not able to
> review the change in detail. However, we discussed my open questions, so
> that I am sure now that it doesn't break anything which is not expected.
> 
> I'm writing "not expected" because there is one known problem though:
> The preview of records that are versioned, but without using workspaces,
> is failing now.
> 
> This is because versioning without using workspaces is still possible,
> though it seems to be broken anyway, not just in this preview.
> 
> Our agreement was that this is considered a buggy feature, which we're
> looking for solutions later. If anyone wants to use versioning, the
> right way to do it for now is using workspaces.
> 
> So this means that the fix for bug #5611 can be committed, considering
> the importance of this problem higher than providing a broken preview
> for versioned / non-workspace records.
> 
> The change is now committed to TYPO3_4-2 and Trunk, see changesets attached.
> 
> - 1st change is non-functional cleanup
> - 2nd change contains the fix
> 
> TYPO3_4-2: rev at 4437 (1) / rev at 4440 (2)
> Trunk:     rev at 4438 (1) / rev at 4439 (2)
> 
> Cheers, and good night!
> - michael
> 
> Michael Stucki wrote:
>> Thanks Ralf for putting this up.
>>
>> The problem with this issue is that it's about versioning, and in fear
>> of breaking something we're not aware of I would like to have Kaspers
>> feedback about it. I have asked him a year ago but think I never got a
>> feedback from him. So I just asked him once again now.
>>
>> Additionally I will try to get Dmitry look into it, as he is probably
>> the person with the best knowledge about versioning next to Kasper.
>>
>> Will keep you posted!
>> - michael
>>
>> Ralf Hettinger schrieb:
>>> This is an SVN patch request.
>>>
>>>
>>> Type: Bug
>>>
>>>
>>> Bugtracker references:
>>> http://bugs.typo3.org/view.php?id=5611
>>>
>>>
>>> Branches:
>>> 4.1, 4.2, trunk (4.3)
>>>
>>>
>>> Problem:
>>> Preview time is not respected correctly in FE when using the admin
>>> panel. As soon as it is set, all content is displayed disregarding any
>>> start- and enddates.
>>>
>>>
>>> Solution:
>>> (quoting Michael Stucki, who reported and -I think- solved the problem)
>>> "It seems like sys_page->versioningPreview is set as soon as
>>> $TSFE->fePreview is true. However, fePreview is not the same like a
>>> versioning preview. Therefore, the check must be changed.
>>>
>>> I'm not sure how to assure if we are in versioningPreview mode, but I
>>> assume that one of these needs to be set:
>>> - t3lib_div::_GP('ADMCMD_view')
>>> - intval($TSFE->workspacePreview)
>>>
>>> That should also cover any versioning preview links (ADMCMD_prev)..."
>>>
>>>
>>> Notes:
>>> As from my experience and by reading the other bt replies, Michael's
>>> patch works like a charm, so I would give this a +1 by myself based on
>>> testing if I wasn't reporting ;)
>>>
>>> Maybe Michael wants to comment his own solution description, which
>>> sounds plausible to me but is written as if he wasn't that sure by himself.
>>>
>>>
>>> Ralf Hettinger (indeed should read Michael Stucki, I think ;) )
>>>
>>>
>>>
>>
> 
>