[TYPO3-core] RFC: #9372: Code in class.tx_tstemplateanalyzer.php don't match with the new CGL
Stefano Kowalke
blueduck at gmx.net
Mon Nov 3 10:25:23 CET 2008
Steffen Kamper schrieb:
> Hi,
>
> Stefano Kowalke schrieb:
>>
>> What do you mean with 'strange line endings'? Settings in Eclipse are
>> Unix. Could you give me a hint, maybe the output from patch.
>>
>> Stefano
>
> the file had empty lines every 2nd row. May be readable with a svn
> command but tortoise denied.
>
> Anyway, there are some small issues:
> * You added descriptions to functions, but not to all
> * when using public/protected with variables, it should be used for
> functions as well
> * found an issue where empty string is added like $a = '' . $xyz
>
> Sry for that, but if you clean a complete file it should be done complete.
Don´t worry. You have absolutly right. Every hint is welcome. I will try
to take yours into account.
Stefano
More information about the TYPO3-team-core
mailing list