[TYPO3-core] RFC: #8543: Enhance page modul

[Steffen Kamper]

Hi Peter,

"Peter Niederlag" <peter at niederlag.de> schrieb im Newsbeitrag 
news:mailman.4062.1212179077.4573.typo3-team-core at lists.netfielders.de...
> Hi Steffen,
>
> Steffen Kamper schrieb:
>> Hi,
>>
>> This is an SVN patch request.
>>
>> Type: Bugfix
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=8504
>> HCI-reference:
>> http://forge.typo3.org/issues/show/667
>>
>> Branches: trunk
>
> 1.
> ($this->columnWidth-6) should IMO rather be (($this->columnWidth)-6) if
> I am not mistaking.
>

why? check to integer was done before, so it's no mistake.

> 2.
> a couple of -....
> if (in_array($row['CType'], array('textpic', 'image', 'splash'))) {
> and
> if ($row['CType'] == 'table' ) {
>
> Wouldn't a switch statement be better?
>

yes, possible. this was a "grown" part. which was completed more and more. I 
will change that to switch/case with next version of the patch.

what do you think beside this notes?

vg Steffen