[TYPO3-core] RFC: #8543: Enhance page modul

Peter Niederlag peter at niederlag.de
Fri May 30 22:24:14 CEST 2008


Hi Steffen,

Steffen Kamper schrieb:
> Hi,
> 
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=8504
> HCI-reference:
> http://forge.typo3.org/issues/show/667
> 
> Branches: trunk

1.
($this->columnWidth-6) should IMO rather be (($this->columnWidth)-6) if
I am not mistaking.

2.
a couple of -....
if (in_array($row['CType'], array('textpic', 'image', 'splash'))) {
and
if ($row['CType'] == 'table' ) {

Wouldn't a switch statement be better?

Greets,
Peter
-- 
Peter Niederlag * Neuer Sandberg 9 * 31535 Neustadt *
Fon (privat): 05036 / 924 100 * Fon (Büro): 05036 / 924 101
Fon (mobil): 0172 / 516 48 55 * Fax 05036 / 924 105
callto:typo3support (skype)
http://www.niekom.de * TYPO3 und EDV Dienstleistungen *



More information about the TYPO3-team-core mailing list