[TYPO3-core] RFC: #8532: enhance TYPO3 manual (inline)

Steffen Kamper steffen at sk-typo3.de
Wed May 28 12:58:55 CEST 2008


"Benjamin Mack" <benni at typo3.org> schrieb im Newsbeitrag 
news:mailman.1.1211971738.12934.typo3-team-core at lists.netfielders.de...
> Hey Steffen,
>
> nice improvement. Generally a +1, but: Some nitpicking.
>
> CSS: Please either use
> font-size:1px
> or
> font-size: 1px
>
> It's mixed in your patch. I recommend using the latter one for 
> readability. I will prepare CSS coding guidelines at some point, until 
> then let's keep it consistent.
>
> Also, this does not make sense to add to the core:
> + /*background-color:#B8BEC9;
> + border:1px solid black;*/
> remove commented out stuff if you don't use it.
>
> You add stuff like this:
> "+ "
> which is a no-go. Other than that the patch looks ok.
>
> Thanks for the screenshot!
>
> -- 

Hi Benni,

you're right. I sended the patch "too early" as it was the progress 
yesterday.
I will post a cleaned patch later today.

vg Steffen 




More information about the TYPO3-team-core mailing list