[TYPO3-core] RFC: #8532: enhance TYPO3 manual (inline)

Benjamin Mack benni at typo3.org
Wed May 28 12:49:15 CEST 2008


Hey Steffen,

nice improvement. Generally a +1, but: Some nitpicking.

CSS: Please either use
	font-size:1px
or
	font-size: 1px

It's mixed in your patch. I recommend using the latter one for 
readability. I will prepare CSS coding guidelines at some point, until 
then let's keep it consistent.

Also, this does not make sense to add to the core:
+	/*background-color:#B8BEC9;
+	border:1px solid black;*/
remove commented out stuff if you don't use it.

You add stuff like this:
"+		"
which is a no-go. Other than that the patch looks ok.

Thanks for the screenshot!

-- 
greetings,
benni.
-SDG-


More information about the TYPO3-team-core mailing list