[TYPO3-core] RFC: #8418: using accessListRenderMode has several bugs

[Jeff Segars]

Steffen Kamper wrote:
> Hi,
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=8414
> 
> Branches: 4.2 or trunk
> 
> Problem:
>  - help is always shown as fulltext regardless the user setting
> - colors are from oldskin (missing in t3skin)
> - has "check all" but not "uncheck all"
> - missing "revert selection"
> 
>  I styled it and added missing functionality, also reformated code to CGL
> 
> I added patch and screenshots.
> To test this use the following setting:
> 
> $TYPO3_CONF_VARS['BE']['accessListRenderMode'] = 'checkbox';
> 
> vg Steffen
> 
> ps: by doing this i saw that setting "display always full helptext" is 
> unusable in 4.2, it's one remaining bug 

Hey Steffen,
Thanks for the fix!  The screenshots look like a nice improvment and I'm 
about to start testing here.

I do see two things in the screenshot that might benefit from some 
tweaking.  If you agree and want to make updates now that's great. It's 
also fine to wait and see if there are other comments first.

1. If we're going to change background colors based on clicks, would we 
be better making the selected state white? It seems like the selected 
state should differ from the background while the unselected state 
should not.

2. When the full help text is displayed, can we drop the gray 
background?  I think bold is enough to differentiate it. There's also 
the question of if that redundant information is even needed, but that's 
a separate issue :)

Off to review....

Thanks,
Jeff