[TYPO3-core] RFC: Fix bug #7729: Login screen needs to be XCLASSable
Martin Kutschker
Martin.Kutschker at n0spam-blackbox.net
Mon Mar 3 17:42:58 CET 2008
Michael Stucki schrieb:
> Hi Oliver,
>
>> just a few nits:
>>
>> + function startForm() {
>>
>> Please change the tab before the { to a space.
>
> We don't do so for functions, only in case of if, while, foreach etc.
> Additionally, notice that this is JavaScript not PHP code!
There was some agreement that we don't like the current tabs between the
function arguments and the first curly brace.
While I think it's nice to have this in our CGL for NEW files, it's
annoying to be asked for every single new line in EXISTING files.
Additionally I think it's better to keep formatting for a file consistent
(be it tabs or no tabs).
Anyone who doesn't like tabs in a particular file may provide a clean.up
patch. But please don't bugger me with the tabs for new functions in
existing code. :-)
Masi
More information about the TYPO3-team-core
mailing list