[TYPO3-core] --review-- RFC: Fix (part of) #7589: FULLTEXT keys are not processed correctly

[Michael Stucki]

Hi Dmitry,

> Applied all except step5, went to Install tool.
> 
> Here is a part of "show create table tt_news" output at my system:
> ------------
>   KEY `parent` (`pid`),
>   KEY `t3ver_oid` (`t3ver_oid`,`t3ver_wsid`),
>   FULLTEXT KEY `fts` (`title`,`bodytext`)
> ) ENGINE=MyISAM AUTO_INCREMENT=7 DEFAULT CHARSET=utf8
> ------------
> 
> In Install tool I see:
> ------------
> |?| ALTER TABLE tt_news ADD FULLTEXT KEY fts (title,bodytext);
> ------------
> 
> Did not expect it, key already exists! Same in EM. And of course I get SQL
> erros after applying proposed change:

I cannot reproduce this, but it seems we figured out it was caused by some
strange patch behaviours...

> Another problem. I have the following declaration for tx_ratings_data in
> ext_tables.sql: ------------
> PRIMARY KEY (uid),
> KEY parent (pid),
> KEY reference (reference(16))
> ) ENGINE = InnoDB;
> ------------
> 
> And I see in Install tool:
> 
> ------------
> |?| ALTER TABLE tx_ratings_data ENGINE=MyISAM;
> Current value: ENGINE=InnoDB
> ------------
> 
> Same for any other table from extensions that declare engine explicitely.
> This is no-go :( I do not want to change these tables to MyISAM. They must
> be InnoDb because they must have high concurrency.

Yeah, I did not allow the spaces around the equal character, but this is
valid SQL of course. Additionally, and after talking to you, I have
modified my code so it does not force any default table engine if nothing
is defined in ext_tables.sql.

See attached patch which is an addition to the previous patches (steps 1-4).

- michael
-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: step6_bugfixes.diff
Type: text/x-diff
Size: 2507 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080303/18c1e607/attachment.diff