[TYPO3-core] RFC: Fix bug #7729: Login screen needs to be XCLASSable

Oliver Klee typo3-german-02 at oliverklee.de
Mon Mar 3 13:16:47 CET 2008


Hi,

just a few nits:

+	function startForm()	{

Please change the tab before the { to a space.

Please add the "public" visibility keyword (or "protected" if the 
function shouldn't be called from outside).

+	function getHiddenFields($challenge)	{

Ditto.

+	function getJScode()	{

Ditto.

I'd prefer a function name without abbreviations (getJavaScriptCode), 
but that's a matter of personal taste in this case, I think.

+	function getChallenge()	{

Ditto.

Regards,


Oliver


More information about the TYPO3-team-core mailing list