[TYPO3-core] RFC: Fix bug #7397: Proxy servers replace REMOTE_ADDR with their own IP

Martin Kutschker martin.kutschker-n0spam at no5pam-blackbox.net
Sun Mar 2 17:08:40 CET 2008


Michael Stucki schrieb:
> Hi Martin,
> 
>>> Most important: Please _always_ check your patches before committing
>>> them! Just run "svn diff" and you would see this, for example: Your patch
>>> removes a line in config_default.php which should stay there (unless you
>>> provide a good reason for it):
>>> - 'SC_mod_web_perm_ajax::dispatch' => [...]
>> Fixed.
> 
> True, however you did again not check your patch. Hunks 3, 4, 5 and 6 of
> class.t3lib_div.php revert changes that were made before! Must be fixed.

True. I cleaned my diff (again). Thanx for checking so thoroughly.

> Rest is fine, +1 again.
> 
> As Ingo already mentioned, this is considered to be a bug. However the
> changes might have some impact which is why this needs to be tested.
> 
> I think that unless anyone objects now, this change should be committed so
> it can be tested in beta3.

I've committed this finally.

Masi


More information about the TYPO3-team-core mailing list