[TYPO3-core] RFC: Resubmission of feature #1585: Logfile by Request URI + configuration of Empty Referer handling + logline hook
Michael Stucki
michael at typo3.org
Sun Mar 2 14:21:04 CET 2008
Hi Steffen,
> One question before i show my patch
> // TODO: This is very hardcoded and needs to be solved better :-)
> if (!is_array($this->config['config'])) {
> $this->config['config'] = array(
> 'stat' => 1,
> 'stat_apache' => 1,
> 'stat_apache_logfile' => 'www-mysite-com.log',
> 'stat_apache_pagenames' => '[request_uri]'
> );
> $doStatistics = $this->statistics_init();
> if ($doStatistics) {
> $this->statistics_init_pagename();
> } else {
> return false;
> }
> }
This is no longer needed since (I thought) we agreed that server errors
should only be reported using t3lib_div::syslog(). So just remove this
part.
> Why should a log forced if not configured? IMHO it's not possible to fill
> in the right values here, so i would return false in this case
The reason why it was hardcoded: When for example a page is not found, there
is also no template loaded. So the setting had to be hardcoded, but of
course this was also the reason why I didn't consider the patch to be
completed :-)
- michael
--
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
More information about the TYPO3-team-core
mailing list