[TYPO3-core] RFC: #8724: getElementsByClassName does not work properly in Firefox 3 and is deprecated in prototype.js

Oliver Hader oliver at typo3.org
Tue Jun 17 13:06:49 CEST 2008


Hi Helmut,

Helmut Hummel schrieb:
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker reference: http://bugs.typo3.org/view.php?id=8724
> 
> Branches: TYPO3_4-2, trunk (probably 4_1)
> 
> The use of getElementsByClassName is deprecated within the prototype 
> framework an causes trouble with the native Firefox implementation (does 
> not work in FF3).
> 
> (lookup: http://ejohn.org/blog/getelementsbyclassname-pre-prototype-16/ 
> for more information regading the problem)
> 
> Solution:
> Replace Element.getElementsByClassName() call with it's prototype 
> pendant Elment.select() as proposed in the document above.
> 
> Remark:
> I tested the patch in FF3, FF2, IE6 and Safari 3.1.1 (on Mac).

Thanks for pointing this out and taking care of it.
I was able to reproduce the behaviour you mentioned with FF3 and Safari 3.1.

+1 on reading and testing (for Trunk and TYPO3_4-2)

I'm fine to have this also in the TYPO3_4-1 branch. But there we have 
PrototypeJS 1.5.0 - thus, we have to change the "select" call to use 
"getElementsBySelector" (same method functionality but, different name 
in 1.5.0).

olly
-- 
Oliver Hader
TYPO3 4.3 Release Manager


More information about the TYPO3-team-core mailing list