[TYPO3-core] RFC #8682: no result check for setlocale via TypoScript

Martin Kutschker martin.kutschker-n0spam at no5pam-blackbox.net
Thu Jun 12 10:10:43 CEST 2008


Ernesto Baschny [cron IT] schrieb:
> Martin Kutschker wrote: on 11.06.2008 18:54:
> 
>> This is a patch request for TYPO3_4-1 and trunk.
> 
> You mean "trunk" only? This is a "new feature".

For me not checking error conditions is a bug. Checking is not a feature 
it's a must. Anyway, I don't insist but I'll ask Ingo for his opinion ;-)

>> Problem: setlocale() triggered by config.locale_all fails silently.
>>
>> Solution: Give the admin via the admin panel a feedback if the setting 
>> of the locale failed.
> 
> That is cool, yes: Very handy!
> 
> I was a bit surprised to find the error message right on the first 
> element in the TypoScript TT stack (where it says "Script Start"). This 
> is not the moment this is called. So I would change the patch to 
> something like it is attached in this mail, so that we have some stack 
> to place the message in and then it appears on the proper position in 
> the processing list (i.e. after "Setting the config-array" and before 
> "Page generation").

Good idea. It seemed odd for me too but your idea didn't came to my mind.

Masi


More information about the TYPO3-team-core mailing list