[TYPO3-core] RFC #8590: Fileadmins folderoverview don`t show 'B' (for byte) after filesize

Benjamin Mack benni at typo3.org
Tue Jun 3 13:55:57 CEST 2008


Hey Stefano and all,

Very nice work. I did some changes to your patch.

* Cleaned up one foreach / while-each and made code more readable
* Added the default labels for t3lib_div as well (I don't like having 
different values in t3lib_div and file_list BY default)
* Set the default second parameter in the line, where it belongs IMHO 
(also very good for IDEs, I can imagine).

Anyway, +1 after reading, haven't tried this patch though.

Also, since it changes some default values, it should go to trunk only.

I also thought of adding the $LANG-> to t3lib_div to get the default, 
but I dunno for sure if we should do that.

-- 
greetings,
benni.
-SDG-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080603_8590_byte_labels.patch
Type: text/x-diff
Size: 3818 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080603/2423396a/attachment.patch 


More information about the TYPO3-team-core mailing list