[TYPO3-core] RFC: #9046: Nested domain linking with domain record on root page

[Tobias Liebig]

Hej,

i've tested the following cases:

-----------------------------
Case 1:
- "Subsite Domain B" has an own template
- with the checkbox "Rootlevel:" is enabled and
- "config.typolinkCheckRootline = 1" is set

Links from domain A to B: correct
Links from domain B to A: correct

Christophers patch does not change this behaviour

-----------------------------
Case 2:
- "Subsite Domain B" has no own template
- config.typolinkCheckRootline = 0

Links from domain A to B: link points to wrong domain
Links from domain B to A: link points to wrong domain

This test case was expected to fail, because 
config.typolinkCheckRootline must be enabled (see tsref)

Christophers patch does not change this behaviour

-----------------------------

Case 3:
- like Case 2, but
- config.typolinkCheckRootline = 1

typolinkCheckRootline = 1

Links from domain A to B: correct
Links from domain B to A: url points to wrong domain > this is the bug!


Christophers patch *changes* this behaviour.
After appling the patch the Links from B to A work like expected

-----------------------------


My conclusion:

config.typolinkCheckRootline = 1
  - seems to be mandatory if working with multiple domains
  - i guess performance is the only reason why this is disabled by
    default.
    am i right?

config.typolinkEnableLinksAcrossDomains
  - it does not change the behaviour in any of my test cases
  - if this is false (0, default) and typolinkCheckRootline is true,
    ALL links are prefixed with the domain name
    is this intended?
  - if the value is set to true (1),
    the links within the same domain are NOT prefixed
    IMHO this should be the default behaviour
  - this property is *not* documented in TSRef!


Christophers patch works fine in my test setup.

So i would give my +1 after reading and testing

As multiple domain handling is really tough stuff, i would recommend 
that Dmitry (as he suggested) and at least one other core-dev - who is 
familiar with this - should investigate this issue


regards
    Tobias



Christopher Hlubek schrieb:
> Hi Dmitry,
> 
> Dmitry Dulepov [typo3] schrieb:
>> Hi!
>>
>> Christopher Hlubek wrote:
>>> This is an SVN patch request.
>>>
>>> Type: Bugfix
>>>
>>> Branches: Trunk, TYPO3_4-2
>>>
>>> Bugtracker references:
>>> http://bugs.typo3.org/view.php?id=9046
>>
>> Patch should be attached to the message.
>>
>> I'd like to review the patch before it is committed. The patch may 
>> affect recent changes that I did and also RealURL. Please, hold commit 
>> if there are two +1s.
>>
> 
> sorry, forgot the patch :)
> 
> It's attached now.
>