[TYPO3-core] RFC #5045, #5077, #8649: Import/Export requires lot of memory

[Bernhard Kraft]

Hello again ...


Attached are 2 diff files ...

one with the postfix "__w" was created using the command:

svn diff --diff-cmd `which diff` -x "-uw"

so tabs and spaces get ignored - the other one contains the complete 
changes (I fixed tabs of { and indenting of comments, and spaces around 
"." concatenation dots for the whole class file) ....


Martin Kutschker schrieb:

> I guess this could work for the xml export as well if you ship the file
> zip as an extra file. Not quite as convenient as a single file but it'd
> work. Though I don't get it why one would need an xml export.

XML still not supported in this patch - if this is a "requirement" it 
wont make it into core - as I do not plan to waste my time on supporting 
xml export of "LARGE" trees. There is also no request for this feature 
in the bugtracker (currently).

> I don't want to go into nitpicking (like "use of new instead of
> t3lib_div::createInstance) right now as I like the idea :-)

Fixed.


> PS: Ok, onme thing: could you please name the feature internally
> sonething like "externalFiles" or "fileContainer"? "saveMemory" doesn't
> really tell what happens. ;-)

Fixed.


I should mention that the files "class.tx_impexp_fileHandler_****" are 
generic in such a way that they could easily find a place in t3lib/ .... 
but for now I think we should leave it As-it-is and probably introduce 
such classes in t3lib/ later on.
I also created a interface for those three classes.

Just have a look at those new classes  - you will surely understand what 
they are meant for ....



The concerns of Olive Klee:
--------------------------------------

 > - Please use a space instead of a tab for between text and the {.

Fixed for both files I modified (the complete files - i replaced them 
using a vim macro) and for the new files I created.


 > - Please add spaces around concatenation dots.

I did in the files which I created newly.
I corrected this in the few lines I modfied in app/index.php
I corrected this in the file class.tx_impexp.php COMPLETLY !


 > - Please use single quotes.

Fixed.

 > - Please align the comments with the code instead of indenting them.

I fixed this in my newly created files.
I fixed this completly in app/index.php and class.tx_impexp.php

 > - Please add spaces after the commas.

I fixed this at the few lines I modified - the method where I changed 
those lines is very large - I would not like
to scan over the complete method and correct those style-issues there ...

For the code I modified or created I do this by default.

 > Please use PHP5 code:
 > - var -> public/private/protected
 > - Please add an access modifier before "function".

I fixed this for my new class-files - I set a access-modfier for methods 
introduced by me (I did not touch old methods as I do not know where and 
how else in TYPO3 they get used - and for me extensions are also part of 
TYPO3 - so probably some extension utilizies methods which you would 
declare as private or protected !!!)

 > What about some PhpDoc comments? These will make understanding and
 > reviewing your code much easier.

I added the PhpDoc comments at the top of methods and classes introduced 
by me ....
--------------------------------------



grüsse,
Bernhard
-- 
Freiheit ist immer Freiheit des Andersdenkenden.
Rosa Luxemburg, 1871-1919
--------------------------------------------------
www.think-open.at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: impexp_memoryfix1_2008-07-24.diff
Type: text/x-patch
Size: 211698 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080724/f6811de5/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: impexp_memoryfix1_2008-07-24__w.diff
Type: text/x-patch
Size: 42583 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080724/f6811de5/attachment-0003.bin