[TYPO3-core] RFC #8985: Enable USER object to become USER_INT on the fly

[Dmitry Dulepov [typo3]]

Hi!

Mostly changed, see comments below. Patch and test extension attached.

Ingo Renner wrote:
> 9, 18: there's IMO no need to add @var for primitive types, should be 
> used only for objects

Done but left comments as /** style (for Zend Studio hints on hover).

> 11: name the variable $doConvertToUserInt or $convertToUserInt - always 
> use lowerCamlCase for variables

Changed to $doConvertToUserInt. Having $convertToUserInt because $this->convertToUserInt is ambigous (is it variable or function address?)

> 27, 34: add a public access designator. What does OT mean? No 
> abbreviations, please.

Constants are always public in PHP. Or did you mean @access?

> 75: couldn't that call be moved into the else branch? Seems to be the 
> only place where $tempContent is used...

Checked, it could not :( There should be a call to userFunc first but result cannot be assigned to $content immediately because it may have to be discarded.

-- 
Dmitry Dulepov
TYPO3 Core team
More about TYPO3: http://typo3bloke.net/
Subscribe: http://typo3bloke.net/rss.xml
Latest article: http://typo3bloke.net/post-details/how_to_fill_realurl_cache/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8985_user2int_v2.diff
Type: text/x-diff
Size: 4104 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080717/2daca07e/attachment-0001.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: T3X_user_user2int-0_2_0-z-200807171222.t3x
Type: application/octet-stream
Size: 30080 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080717/2daca07e/attachment-0001.obj