[TYPO3-core] FYI: Fixed bug #8717 (cleanup): htmlArea RTE link browser does not honour correctly hooking browsers

[Ernesto Baschny [cron IT]]

Dmitry Dulepov [typo3] wrote: on 08.07.2008 08:02:
> Hi!
> 
> Michael Stucki wrote:
>> in this change a hook is renamed, which is pretty delicate already. 
>> However,
>> the ChangeLog entry doesn't even mention this, it just contains the
>> original subject with an additional "cleanup" remark.
> 
> I would say existing hooks should never be renamed. New one should be 
> added if necessary. Renaming hooks breaks compatibility.

Hi,

if I read the report from Stan and the diff correctly, this is not a 
renaming of an existing hook, but the creation of a new one.

RTE was (mis)using the existing hook 
['typo3/class.browse_links.php']['browseLinksHook'], but this hook is 
already being used on other situations (as Stan says other classes also 
extend browse_links).

So if someone creates a hook to the browse-links provided by 
rtehtmlarea, this hook might create errors when being called from 
another class that extends browse_links and has a different context than 
rtehtmlarea. So the bugfix is to make the rtehtmlarea hook (new) and 
unique to rtehtmlarea.

I think what is missing is of course the specific remark in the 
ChangeLog stating clearly what was changed.

Cheers,
Ernesto