[TYPO3-core] RFC #8913: Empty tabs in DynTabMenu should not be selectable by default

Christian Kuhn lolli at schwarzbu.ch
Mon Jul 7 18:47:01 CEST 2008


+1 reading and testing.

Patch does not apply to 4-1 branch, but can easily be fixed by hand.


Cheers
Christian

Benjamin Mack wrote:
> Hey all,
> 
> this is a SVN patch request.
> 
> Branches: TYPO3_4-1, TYPO3_4.2 and trunk
> 
> Type: nobrainer-bugfix
> 
> BT reference: http://bugs.typo3.org/view.php?id=8913
> 
> Problem:
> If you've ever used the TemplaVoila page module with the dyntabs on top, 
> you'll notice that if you empty your unused elements, the selection gets 
> somehow yellow, instead of grey (unclickable). The reason is the following:
> 
> Once the page loads, it sets the "disabled" flag for every empty tab. 
> However, if the session states that the tab is active (because it was 
> active before) and the whole dyntabmenu is toggable, there is a call to 
> set the content (which is empty) to "block" instead of none.
> 
> Solution:
> So for empty tabs the initial "show tab" call when the page is loaded 
> should not be made.
> 
> See the screenshots for clarification.
> 
> The first screenshot (nonempty) shows a typical expanded tab. Once you 
> click on "remove unused items", the tab looks like "before.png", but 
> with the patch it looks like "after.png" (= as it should).
> 
> 
> ------------------------------------------------------------------------
> 
> 
> ------------------------------------------------------------------------
> 
> 
> ------------------------------------------------------------------------
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/ 
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core



More information about the TYPO3-team-core mailing list