[TYPO3-core] RFC #8913: Empty tabs in DynTabMenu should not be selectable by default

Benjamin Mack benni at typo3.org
Mon Jul 7 13:53:55 CEST 2008


Hey all,

this is a SVN patch request.

Branches: TYPO3_4-1, TYPO3_4.2 and trunk

Type: nobrainer-bugfix

BT reference: http://bugs.typo3.org/view.php?id=8913

Problem:
If you've ever used the TemplaVoila page module with the dyntabs on top, 
you'll notice that if you empty your unused elements, the selection gets 
somehow yellow, instead of grey (unclickable). The reason is the following:

Once the page loads, it sets the "disabled" flag for every empty tab. 
However, if the session states that the tab is active (because it was 
active before) and the whole dyntabmenu is toggable, there is a call to 
set the content (which is empty) to "block" instead of none.

Solution:
So for empty tabs the initial "show tab" call when the page is loaded 
should not be made.

See the screenshots for clarification.

The first screenshot (nonempty) shows a typical expanded tab. Once you 
click on "remove unused items", the tab looks like "before.png", but 
with the patch it looks like "after.png" (= as it should).

-- 
greetings,
benni.
-SDG-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nonempty.png
Type: image/png
Size: 8117 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080707/78db4ec3/attachment.png 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: before.png
Type: image/png
Size: 5942 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080707/78db4ec3/attachment-0001.png 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: after.png
Type: image/png
Size: 4929 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080707/78db4ec3/attachment-0002.png 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080707_dyntabs_nonempty.patch
Type: text/x-diff
Size: 562 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080707/78db4ec3/attachment.patch 


More information about the TYPO3-team-core mailing list