[TYPO3-core] RFC: #7333: Solution for "Page is being generated"

[Ingo Renner]

Bernhard Kraft wrote:

Hi Bernhard,

> BT:
> http://bugs.typo3.org/view.php?id=7333
> 
> Problem:
> Get rid of this "Page is being generated" screen ...

tested: works, couldn't get PIBG messages anymore! (note: I had to 
create typo3temp/pagegen_lock/ with correct access rights before)

some remarks on the patch itself:

* lockPageGenerate -> lockPageGeneration
* please split lockPageGenerate into lock... and unlock...
* lockPageGenerate is missing phpDoc
* please transform lockPageGenerate so that you have just one single 
return statement
* in index_tx.php please find a better variable name than $ok - what 
exactly is ok?
* please clean this block up by properly using curly braces, otherwise 
it's really hard to understand:

+		if ($TSFE->TYPO3_CONF_VARS['FE']['disablePageIsBeingGenerated']>0)	{
+			$ok = $TSFE->lockPageGenerate(1);
+			if (!$ok)	{
+			if ($GLOBALS['debugPageIsBeingGenerated']) debug_PIBG("aquired 
blocking lock - rereading cache ...");
+				$TSFE->getFromCache();
+			} else	{
+				if ($GLOBALS['debugPageIsBeingGenerated']) debug_PIBG("aquired 
nonblocking lock ...");
+			}
+		}


so +1 after testing and reading if you make these changes.


all the best
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2