[TYPO3-core] RFC: #7148 - CSV Export Improvements in List Module

Benjamin Mack mack at xnos.org
Tue Jan 15 11:37:15 CET 2008


Hey Oliver,

Oliver Klee wrote:
> +		if ($this->csvOutput) {	// do not do paging when outputting as CSV
> +			$this->iLimit = 0;
> +		}
> 
> Do we really need this if we have the following part lateron?
Yes, if you try the patch and remove this one, you'll see.

> Here, the break if missing. If this is intentional, please add a comment
> "This fall-through is intended." so it's clear that this is not a bug.
Done.

See the attached patch.

-- 
greetings,
benni.
-SDG-

www.xnos.de // www.xnos.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20080115_csv_fixes.patch
Type: text/x-patch
Size: 3415 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20080115/d2752eac/attachment.bin 


More information about the TYPO3-team-core mailing list