[TYPO3-core] RFC: #7148 - CSV Export Improvements in List Module

[Oliver Klee]

Hi,

+1 if you fix the following nits:

+		if ($this->csvOutput) {	// do not do paging when outputting as CSV
+			$this->iLimit = 0;
+		}

Do we really need this if we have the following part lateron?

+			if ($this->csvOutput) {
+				$this->showLimit = $this->totalItems;
+				$this->iLimit = $this->totalItems;
+			}


+					$tmpProc =
t3lib_BEfunc::getProcessedValueExtra($table,$fCol,$row[$fCol],100,$row['uid']);

Spaces after the commas would improve readability here.

+		foreach ($this->fieldArray as $fN) {
+
+			switch ($fN) {

Please drop this empty line.

+				case '_REF_':
+					$csvRow[] = $this->makeRef($table, $row['uid']);
+
+				case '_CONTROL_':

Here, the break if missing. If this is intentional, please add a comment
"This fall-through is intended." so it's clear that this is not a bug.

+				case '_CONTROL_':
+				case '_CLIPBOARD_':

Here, please also add a comment that the fallthrough is intended.


Regards,


Oliver