[TYPO3-core] RFC: Feature Request #2797: sendFlag for mail in htmlmail

Steffen Kamper steffen at sk-typo3.de
Sat Jan 12 13:45:36 CET 2008


"Oliver Hader" <oh at inpublica.de> schrieb im Newsbeitrag 
news:mailman.1.1200140582.30127.typo3-team-core at lists.netfielders.de...
> Hi Steffen,
>
> Steffen Kamper schrieb:
>> Type: Feature
>>
>> Branches: Trunk only
>>
>> BT reference: http://bugs.typo3.org/view.php?id=2797
>>
>> Problem:
>> The class htmlmail.did not have a flag or return value to see if mail was
>> successful
>>
>> Solution:
>> Simply added a flag $sendFlag
>>
>> usage:
>> $htmlmail->sendTheMail();
>> if(!$htmlmail->sendFlag) {
>> //mail was not sent
>> ...
>> }
>
> The patch looks good so far. +1 on reading
>
> Just two changes I'd like to see:
> * lets call the ne variable 'wasSent' or 'mailWasSent'
> * could you please change the formatting like e.g. this:
> $this->wasSent = mail(
> $this->recipient_copy,
> $this->subject,
> $this->message,
> $this->headers
> );
>
> olly
> -- 

Hi olly,

i did the changes, var is named now $this->mailWasSent.
I also inserted some spaces at the beginning.
New patch is attached.

vg  Steffen 


begin 666 20080112_htmlmail_sendflag2.diff
M26YD97 at Z('0S;&EB+V-L87-S+G0S;&EB7VAT;6QM86EL+G!H< T*/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/0T*+2TM('0S;&EB+V-L87-S+G0S;&EB7VAT;6QM
M86EL+G!H< DH<F5V:7-I;VX@,C at X,BD-"BLK*R!T,VQI8B]C;&%S<RYT,VQI
M8E]H=&UL;6%I;"YP:' )*'=O<FMI;F<@8V]P>2D-"D! ("TR,#(L,30@*S(P
M,BPQ-2! 0 T*( EV87(@)&]R9V%N:7-A=&EO;B ](")9;W5R($-O;7!A;GDB
M.PH@"79A<B D<')I;W)I='D@/2 S.R @("\O(#$@/2!H:6=H97-T+" U(#T@
M;&]W97-T+" S(#T@;F]R;6%L"B )=F%R("1M86EL97(@/2 B4$A0(&UA:6QE
M<B(["2\O(%@M;6%I;&5R"BT)=F%R("1A;'1?8F%S938T/3 ["BT)=F%R("1A
M;'1?.&)I=#TP.PHM"79A<B D:G5M<&5R55),7W!R969I>" ](B(["0DO+R!4
M:&ES(&ES(&$@<')E9FEX('1H870@=VEL;"!B92!A9&1E9"!T;R!A;&P@;&EN
M:W,@:6X@=&AE(&UA:6PN($5X86UP;&4Z("=H='1P.B\O=W=W+FUY9&]M86EN
M+F-O;2]J=6UP/W5S97)I9#TC(R-&245,1%]U:60C(R,F=7)L/2<N(&EF('5S
M960L(&%N>71H:6YG(&%F=&5R('5R;#T@:7,@=7)L96YC;V1E9"X*+0EV87(@
M)&IU;7!E<E523%]U<V5)9#TP.PD)"2\O($EF('-E="P@=&AE;B!T:&4 at 87)R
M87DM:V5Y(&]F('1H92!U<FQS(&%R92!I;G-E<G1E9"!I;G-T96%D(&]F('1H
M92!U<FP@:71S96QF+B!3;6%R="!I;B!O<F1E<B!T;R!R961U8V4@;&EN:RUL
M96YG=&@*+0EV87(@)&UE9&EA3&ES=#TB(CL)"0D)+R\@268@<V5T+"!T:&ES
M(&ES(&$@;&ES="!O9B!T:&4@;65D:6$M9FEL97,@*&EN9&5X+6ME>7,@=&\@
M=&AE(&%R<F%Y*2!T:&%T('-H;W5L9"!B92!R97!R97-E;G1E9"!I;B!T:&4@
M:'1M;"UM86EL"BT)=F%R("1H='1P7W!A<W-W;W)D/2(B.PHM"79A<B D:'1T
M<%]U<V5R;F%M93TB(CL*+0EV87(@)'!O<W1F:7A?=F5R<VEO;C$]9F%L<V4[
M"BL)=F%R("1A;'1?8F%S938T(#T@,#L**PEV87(@)&%L=%\X8FET(#T@,#L*
M*PEV87(@)&IU;7!E<E523%]P<F5F:7@@/2 B(CL)"2\O(%1H:7,@:7, at 82!P
M<F5F:7@@=&AA="!W:6QL(&)E(&%D9&5D('1O(&%L;"!L:6YK<R!I;B!T:&4@
M;6%I;"X at 17AA;7!L93H@)VAT=' Z+R]W=W<N;7ED;VUA:6XN8V]M+VIU;7 _
M=7-E<FED/2,C(T9)14Q$7W5I9",C(R9U<FP])RX@:68@=7-E9"P at 86YY=&AI
M;F<@869T97(@=7)L/2!I<R!U<FQE;F-O9&5D+ at HK"79A<B D:G5M<&5R55),
M7W5S94ED(#T@,#L)"0DO+R!)9B!S970L('1H96X@=&AE(&%R<F%Y+6ME>2!O
M9B!T:&4@=7)L<R!A<F4@:6YS97)T960@:6YS=&5A9"!O9B!T:&4@=7)L(&ET
M<V5L9BX at 4VUA<G0@:6X@;W)D97(@=&\@<F5D=6-E(&QI;FLM;&5N9W1H"BL)
M=F%R("1M961I84QI<W0@/2 B(CL)"0D)+R\@268@<V5T+"!T:&ES(&ES(&$@
M;&ES="!O9B!T:&4@;65D:6$M9FEL97,@*&EN9&5X+6ME>7,@=&\@=&AE(&%R
M<F%Y*2!T:&%T('-H;W5L9"!B92!R97!R97-E;G1E9"!I;B!T:&4@:'1M;"UM
M86EL"BL)=F%R("1H='1P7W!A<W-W;W)D(#T@(B(["BL)=F%R("1H='1P7W5S
M97)N86UE(#T@(B(["BL)=F%R("1P;W-T9FEX7W9E<G-I;VXQ(#T at 9F%L<V4[
M"BL)=F%R("1M86EL5V%S4V5N=" ](&9A;'-E.PDO+V9L86<@9F]R(&9U;F-T
M:6]N(&UA:6PL(&EF(&UA:6P@<V5N9&EN9R!W87,@<W5C8V5S<V9U; H@"B )
M+R\@26YT97)N86P*( I 0" M-CDP+#<@*S8Y,2PW($! #0H@"2 J($!R971U
M<FX)6W1Y<&5="0DN+BX*( D@*B\*( EF=6YC=&EO;B!S96YD5&AE36%I;" H
M*2!["BTC9&5B=6<H87)R87DH)'1H:7,M/G)E8VEP:65N="PD=&AI<RT^<W5B
M:F5C="PD=&AI<RT^;65S<V%G92PD=&AI<RT^:&5A9&5R<RDI.PHK"0DD=&AI
M<RT^;6%I;%=A<U-E;G0@/2!F86QS93L*( D)"2\O(%-E;F1S('1H92!M86EL
M+"!R97%U:7)E<R!T:&4@<F5C:7!I96YT+"!M97-S86=E(&%N9"!H96%D97)S
M('1O(&)E('-E="X*( D):68@*'1R:6TH)'1H:7,M/G)E8VEP:65N="D@)B8@
M=')I;2 at D=&AI<RT^;65S<V%G92DI"7L)+R\@("8F('1R:6TH)'1H:7,M/FAE
M861E<G,I"B )"0DD<F5T=7)N4&%T:" ]("AS=')L96XH)'1H:7,M/G)E='5R
M;E!A=&@I/C I/R(M9B(N)'1H:7,M/G)E='5R;E!A=&@Z)R<["D! ("TW,# L
M,S @*S<P,2PS."! 0 T*( D)"7T*( D)"0DO+TEF('-A9F4@;6]D92!I<R!O
M;BP@=&AE(&9I9G1H('!A<F%M971E<B!T;R!M86EL(&ES(&YO="!A;&QO=V5D
M+"!S;R!T:&4 at 9FEX('=O;G0@=V]R:R!O;B!U;FEX('=I=&@@<V%F95]M;V1E
M/4]N"B )"0EI9B at A:6YI7V=E="@G<V%F95]M;V1E)RD@)B8@)'1H:7,M/F9O
M<F-E4F5T=7)N4&%T:"D@>PHM"0D)"6UA:6PH)'1H:7,M/G)E8VEP:65N="P*
M+0D)"0D)(" D=&AI<RT^<W5B:F5C="P*+0D)"0D)(" D=&AI<RT^;65S<V%G
M92P*+0D)"0D)(" D=&AI<RT^:&5A9&5R<RP*+0D)"0D)(" D<F5T=7)N4&%T
M:"D["BL)"0D))'1H:7,M/FUA:6Q787-396YT(#T@;6%I;"@**PD)"0D))'1H
M:7,M/G)E8VEP:65N="P**PD)"0D))'1H:7,M/G-U8FIE8W0L"BL)"0D)"21T
M:&ES+3YM97-S86=E+ HK"0D)"0DD=&AI<RT^:&5A9&5R<RP**PD)"0D))')E
M='5R;E!A=&@**PD)"0DI.PH@"0D)?2!E;'-E('L*+0D)"0EM86EL*"1T:&ES
M+3YR96-I<&EE;G0L"BT)"0D)"2 @)'1H:7,M/G-U8FIE8W0L"BT)"0D)"2 @
M)'1H:7,M/FUE<W-A9V4L"BT)"0D)"2 @)'1H:7,M/FAE861E<G,I.PHK"0D)
M"21T:&ES+3YM86EL5V%S4V5N=" ](&UA:6PH"BL)"0D)"21T:&ES+3YR96-I
M<&EE;G0L"BL)"0D)"21T:&ES+3YS=6)J96-T+ HK"0D)"0DD=&AI<RT^;65S
M<V%G92P**PD)"0D))'1H:7,M/FAE861E<G,**PD)"0DI.PH@"0D)?0H@"0D)
M"2\O(%-E;F1I;F<@8V]P>3H*( D)"6EF("@D=&AI<RT^<F5C:7!I96YT7V-O
M<'DI"7L*( D)"0EI9B at A:6YI7V=E="@G<V%F95]M;V1E)RD@)B8@)'1H:7,M
M/F9O<F-E4F5T=7)N4&%T:"D@>PHM"0D)"0EM86EL*" ))'1H:7,M/G)E8VEP
M:65N=%]C;W!Y+ HM"0D)"0D)"0DD=&AI<RT^<W5B:F5C="P*+0D)"0D)"0D)
M)'1H:7,M/FUE<W-A9V4L"BT)"0D)"0D)"21T:&ES+3YH96%D97)S+ HM"0D)
M"0D)"0DD<F5T=7)N4&%T:"D["BL)"0D)"21T:&ES+3YM86EL5V%S4V5N=" ]
M(&UA:6PH"BL)"0D)"0DD=&AI<RT^<F5C:7!I96YT7V-O<'DL"BL)"0D)"0DD
M=&AI<RT^<W5B:F5C="P**PD)"0D)"21T:&ES+3YM97-S86=E+ HK"0D)"0D)
M)'1H:7,M/FAE861E<G,L"BL)"0D)"0DD<F5T=7)N4&%T: HK"0D)"0DI.PH@
M"0D)"7T at 96QS92!["BT)"0D)"6UA:6PH( DD=&AI<RT^<F5C:7!I96YT7V-O
M<'DL"BT)"0D)"0D)"21T:&ES+3YS=6)J96-T+ HM"0D)"0D)"0DD=&AI<RT^
M;65S<V%G92P*+0D)"0D)"0D))'1H:7,M/FAE861E<G,)*3L**PD)"0D))'1H
M:7,M/FUA:6Q787-396YT(#T@;6%I;"@**PD)"0D)"21T:&ES+3YR96-I<&EE
M;G1?8V]P>2P**PD)"0D)"21T:&ES+3YS=6)J96-T+ HK"0D)"0D))'1H:7,M
M/FUE<W-A9V4L"BL)"0D)"0DD=&AI<RT^:&5A9&5R<PHK"0D)"0DI.PH@"0D)
M"7T*( D)"7T*( D)"0DO+R!!=71O(')E<W!O;G-E"D! ("TW,S$L,38@*S<T
M,"PR,"! 0 T*( D)"0DD=&AE4&%R=',@/2!E>'!L;V1E*"<O)RPD=&AI<RT^
M875T;U]R97-P;VYD7VUS9RPR*3L*( D)"0DD=&AE4&%R='-;,5T@/2!S=')?
M<F5P;&%C92 at B+R(L8VAR*#$P*2PD=&AE4&%R='-;,5TI.PH@"0D)"6EF*"%I
M;FE?9V5T*"=S869E7VUO9&4G*2 F)B D=&AI<RT^9F]R8V52971U<FY0871H
M*2!["BT)"0D)"6UA:6PH( DD=&AI<RT^9G)O;5]E;6%I;"P*+0D)"0D)"0D)
M)'1H95!A<G1S6S!=+ HM"0D)"0D)"0DD=&AE4&%R='-;,5TL"BT)"0D)"0D)
M"2)&<F]M.B B+B1T:&ES+3YR96-I<&EE;G0L"BT)"0D)"0D)"21R971U<FY0
M871H*3L**PD)"0D))'1H:7,M/FUA:6Q787-396YT(#T@;6%I;"@**PD)"0D)
M"21T:&ES+3YF<F]M7V5M86EL+ HK"0D)"0D))'1H95!A<G1S6S!=+ HK"0D)
M"0D))'1H95!A<G1S6S%=+ HK"0D)"0D)(D9R;VTZ("(N)'1H:7,M/G)E8VEP
M:65N="P**PD)"0D)"21R971U<FY0871H"BL)"0D)"2D["B )"0D)?2!E;'-E
M('L*+0D)"0D);6%I;"@@"21T:&ES+3YF<F]M7V5M86EL+ HM"0D)"0D)"0DD
M=&AE4&%R='-;,%TL"BT)"0D)"0D)"21T:&5087)T<ULQ72P*+0D)"0D)"0D)
M(D9R;VTZ("(N)'1H:7,M/G)E8VEP:65N="D["BL)"0D)"21T:&ES+3YM86EL
M5V%S4V5N=" ](&UA:6PH"BL)"0D)"0DD=&AI<RT^9G)O;5]E;6%I;"P**PD)
M"0D)"21T:&5087)T<ULP72P**PD)"0D)"21T:&5087)T<ULQ72P**PD)"0D)
M"2)&<F]M.B B+B1T:&ES+3YR96-I<&EE;G0**PD)"0D)*3L*( D)"0E]"B )
M"0E]"B )"0EI9B at D=&AI<RT^<F5T=7)N4&%T:"D@>PI 0" M,30S,BPT("LQ
M-#0U+#0 at 0$ -"B!I9B H9&5F:6YE9"@G5%E03S-?34]$12<I("8F("1465!/
M,U]#3TY&7U9!4E-;5%E03S-?34]$15U;)UA#3$%34R==6R=T,VQI8B]C;&%S
M<RYT,VQI8E]H=&UL;6%I;"YP:' G72D)>PH@"6EN8VQU9&5?;VYC92 at D5%E0
M3S-?0T].1E]605)36U194$\S7TU/1$5=6R=80TQ!4U,G75LG=#-L:6(O8VQA
M<W,N=#-L:6)?:'1M;&UA:6PN<&AP)UTI.PH@?0HM/SX-"EP at 3F\@;F5W;&EN
692!A="!E;F0@;V8 at 9FEL90T**S\^"@``
`
end



More information about the TYPO3-team-core mailing list