[TYPO3-core] RFC: Feature Request #2797: sendFlag for mail in htmlmail
Oliver Hader
oh at inpublica.de
Sat Jan 12 13:23:03 CET 2008
Hi Steffen,
Steffen Kamper schrieb:
> Type: Feature
>
> Branches: Trunk only
>
> BT reference: http://bugs.typo3.org/view.php?id=2797
>
> Problem:
> The class htmlmail.did not have a flag or return value to see if mail was
> successful
>
> Solution:
> Simply added a flag $sendFlag
>
> usage:
> $htmlmail->sendTheMail();
> if(!$htmlmail->sendFlag) {
> //mail was not sent
> ...
> }
The patch looks good so far. +1 on reading
Just two changes I'd like to see:
* lets call the ne variable 'wasSent' or 'mailWasSent'
* could you please change the formatting like e.g. this:
$this->wasSent = mail(
$this->recipient_copy,
$this->subject,
$this->message,
$this->headers
);
olly
--
Oliver Hader
http://inpublica.de/
More information about the TYPO3-team-core
mailing list